Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining orphan break by sweeping hidden inline token forcibly #114

Merged
merged 3 commits into from
Dec 25, 2018

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Dec 25, 2018

I've found that the sweep plugin does not handle the HTML breaks rendered when markdown-it's breaks option is enabled. markdown-it does not treat hidden flag for inline token.

![bg](https://github.com/yhatt.png)
![bg](https://github.com/marp-team.png)

# Hello

Unexpected orphan break

It causes by the behavior of markdown-it. The inline token is not treat hidden flag.

Marpit sweep plugin will rename the token type into unique name: marpit_hidden_inline. hidden: true becomes to work for unknown tokens, so we can sweep hidden inline token forcibly.

@yhatt yhatt added the bug Something isn't working label Dec 25, 2018
@yhatt yhatt changed the title Fix to sweep hidden inline token forcibly Fix remaining an orphan break by sweeping hidden inline token forcibly Dec 25, 2018
@yhatt yhatt changed the title Fix remaining an orphan break by sweeping hidden inline token forcibly Fix remaining orphan break by sweeping hidden inline token forcibly Dec 25, 2018
@yhatt yhatt merged commit cc6a177 into master Dec 25, 2018
@yhatt yhatt deleted the sweep-hidden-inline-forcely branch December 25, 2018 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant