Enhance plugin system to control Marpit features #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marpit user should want to use Marpit feature. We should not make Marpit able to disable easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We enhanced markdown-it plugin system to be able to toggle Marpit features by the plugin. markdown-it's
StateCorehasmarpit(), and you can turn off Marpit core rules by callingmarpit(false)beforenormalizerule.Motivation
Marpit has an interface of markdown-it plugin and can extend a plain markdown-it by
marpit.markdownItPlugins. We are planning to create Marp VSCode plugin by making use of this ability. (yhatt/marp#118)Currently, Marpit cannot disable by injected markdown-it instance. But this implementation would get a skill to control Marpit features.