Token finalization to replace imprimitive attribute string #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhatt
commented
Jun 4, 2019
|
|
||
| context('with header image via directive', () => { | ||
| const tokens = md().parse( | ||
| '<!-- header: "" -->\n\n' |
There was a problem hiding this comment.
NOTE: Image in header directive is an edge case of #165 that try to override exists State#process function twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To detect Marpit's color shorthand by the value before validation, Marpit v1.1.0 uses imprimitive string created by
new String('foobar')as an attribute for URL. (#165)By this change, we found that it has breaking an integration with the markdown-it renderer in Marp for VS Code. (
typeof new String('foobar')returnsobject, notstring) marp-vscode v0.5.0 has fixed a render rule individually.I've added token finalization to replace imprimitive attribute string with primitive value by
toString().markdown-it always expects
stringas the attribute value. Thus, we believe that this finalization would not cause any other integration problems.