Fix over-stripped comments in the inline code #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
#25 gives a hint how to resolve this bug. We could resolve by parsing comment as like as markdown-it's html block rule. |
yhatt
changed the title
yhatt
commented
May 27, 2018
| }) | ||
|
|
||
| it('strips comment in rendering', () => { | ||
| // TODO: Supports inline comment | ||
| it.skip('strips comment in rendering', () => { |
There was a problem hiding this comment.
The inline comment will become not to work by parsing comment as HTML block.
In the current use case (directive), this change may almost not affect the user. However, we are planning to use HTML comment as presenter notes in Marp. The inline comment will become to be used when a tool integrated with Marpit implements the presentation mode.
Currently, we mark a test case as pending.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix over-stripped comments in the inline code on Marpit comment plugin.
We discover that a HTML comment wrapping by backtiks (
`<!-- like this -->`) is vanished. This caused by processing parse comments earliar than the inline codes.We are thinking that it solve by adding rule for inline parsing of comments like a background image plugin.