Improve rendering header and footer to use inline tokens #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will improve rendering of header/footer defined by directives, to use inline tokens instead of pre-rendered HTML.
So far, we are using
html_blocktoken for rendered the result ofMarkdownIt.renderInline()directly. However, it has occured over-sanitizing HTML in @marp-team/marp-core. (Refer to this commit whose the added test has been failed)Thus, we should use tokens rendered by
parseInlineinstead of the raw HTML ofrenderInline. We also have added the validation whether directive is a string to prevent passing invalid value toparseInline.Related to yhatt/marp#243.