-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link field to store absolute and relative URI, including URL and URN. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on an updated marrow.util.url utility.
Codecov Report
@@ Coverage Diff @@
## develop #39 +/- ##
===========================================
- Coverage 100% 99.94% -0.06%
===========================================
Files 30 49 +19
Lines 1537 1773 +236
===========================================
+ Hits 1537 1772 +235
- Misses 0 1 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.enhancement
New ideas or improvements.
area:field
Issues relating to Field implementations or their mechanics.
need:test
For task completion, tests covering the development are required.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must be able to store:
Complete URLs, including all URL components.
http://user:pass@host:port/path?query#fragment
Valid non-HTTP URI, including URN.
mailto:user@example.com
urn:ISBN0-486-27557-4
Incomplete or partial URLs in various formats.
//example.com/protocol/relative
/host/relative
local/relative
#fragment-only
Additional changes: