Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link field to store absolute and relative URI, including URL and URN. #39

Merged
merged 20 commits into from
May 21, 2017

Conversation

amcgregor
Copy link
Member

@amcgregor amcgregor commented May 20, 2017

Must be able to store:

  • Complete URLs, including all URL components.
    http://user:pass@host:port/path?query#fragment

  • Valid non-HTTP URI, including URN.
    mailto:user@example.com
    urn:ISBN0-486-27557-4

  • Incomplete or partial URLs in various formats.
    //example.com/protocol/relative
    /host/relative
    local/relative
    #fragment-only

Additional changes:

@amcgregor amcgregor added 2.enhancement New ideas or improvements. area:field Issues relating to Field implementations or their mechanics. need:test For task completion, tests covering the development are required. labels May 20, 2017
@amcgregor amcgregor added this to the 1.1.2 Release milestone May 20, 2017
@codecov
Copy link

codecov bot commented May 20, 2017

Codecov Report

Merging #39 into develop will decrease coverage by 0.05%.
The diff coverage is 99.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #39      +/-   ##
===========================================
- Coverage      100%   99.94%   -0.06%     
===========================================
  Files           30       49      +19     
  Lines         1537     1773     +236     
===========================================
+ Hits          1537     1772     +235     
- Misses           0        1       +1
Impacted Files Coverage Δ
marrow/mongo/core/field/base.py 100% <100%> (ø) ⬆️
marrow/mongo/core/field/ttl.py 100% <100%> (ø)
marrow/mongo/core/field/reference.py 100% <100%> (ø)
marrow/mongo/core/field/link.py 100% <100%> (ø)
marrow/mongo/core/field/boolean.py 100% <100%> (ø)
marrow/mongo/core/field/double.py 100% <100%> (ø)
marrow/mongo/core/field/date.py 100% <100%> (ø)
marrow/mongo/core/field/period.py 100% <100%> (ø)
marrow/mongo/core/field/decimal_.py 100% <100%> (ø)
marrow/mongo/core/field/oid.py 100% <100%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4667e10...8708f69. Read the comment docs.

@amcgregor amcgregor merged commit bd059f5 into develop May 21, 2017
@amcgregor amcgregor deleted the feature/link-field branch May 21, 2017 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.enhancement New ideas or improvements. area:field Issues relating to Field implementations or their mechanics. need:test For task completion, tests covering the development are required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant