Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable the from/to vineyard test cases, and set meta for tensor/dataframe properly. #1967

Merged
merged 9 commits into from
Feb 5, 2021
Merged

Re-enable the from/to vineyard test cases, and set meta for tensor/dataframe properly. #1967

merged 9 commits into from
Feb 5, 2021

Conversation

sighingnow
Copy link
Contributor

What do these changes do?

This pull request fixes the diff coverage problem imposed by #1952 as well.

Related issue number

N/A

acezen and others added 4 commits February 4, 2021 15:06
@acezen @sighingnow
give the real metadata in from vineyard
6f50030
@sighingnow
Re-enable the from/to vineyard test cases, and set meta for tensor/da…
cee516a 
…taframe properly.

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow
Add a "vineyard" profile to dependencies.
ca40990 
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow
Fixes the coverage for pr mars-project#1952.
35100ae 
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow
Fixes.
f6bd8c9 
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@qinxuye qinxuye added mod: vineyard integration type: bug Something isn't working labels Feb 4, 2021
@qinxuye qinxuye added this to the v0.7.0a6 milestone Feb 4, 2021
@sighingnow
The websession itself has chances to timeout.
6434c5d 
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow
Fixes...
5c49e26 
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow
Copy link
Contributor Author

sighingnow commented Feb 4, 2021 •
edited
Loading

Any comment?

I just found a bug in vineyard that will affect this PR, will come back here tomorrow 😢

@sighingnow
Mark as global object.
9795dd0 
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow sighingnow marked this pull request as draft February 4, 2021 12:52
@sighingnow
Use a newer version of vineyard.
318c6e5 
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow sighingnow force-pushed the feature/vineyard_from_to branch from 85555ef to 318c6e5 Compare February 5, 2021 02:17
@sighingnow sighingnow marked this pull request as ready for review February 5, 2021 02:22
@sighingnow
Copy link
Contributor Author

Ready for review now.

qinxuye
qinxuye approved these changes Feb 5, 2021
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 84e4614 into mars-project:master Feb 5, 2021
hekaisheng pushed a commit to hekaisheng/mars that referenced this pull request Mar 8, 2021
@sighingnow
Re-enable the from/to vineyard test cases, and set meta for tensor/da…
e6570c5 
…taframe properly. (mars-project#1967)

Co-authored-by: qiaozi.zwb <qiaozi.zwb@alibaba-inc.com>

(cherry picked from commit 84e4614)
@hekaisheng hekaisheng mentioned this pull request Mar 8, 2021
Merged
@qinxuye qinxuye added the to be backported Indicate that the PR need to be backported to stable branch label Mar 8, 2021
wjsi pushed a commit that referenced this pull request Mar 8, 2021
@hekaisheng @acezen @sighingnow
[BACKPORT] Re-enable the from/to vineyard test cases, and set meta fo…
0badf47 
…r tensor/dataframe properly. (#1967) (#2030)

Co-authored-by: qiaozi.zwb <qiaozi.zwb@alibaba-inc.com>
Co-authored-by: Tao He <linzhu.ht@alibaba-inc.com>
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng Awaiting requested review from hekaisheng

@wjsi wjsi Awaiting requested review from wjsi

Assignees
No one assigned
Labels
backported already PR has been backported mod: vineyard integration type: bug Something isn't working
Projects
None yet
Milestone
v0.7.0a6
Development

Successfully merging this pull request may close these issues.
3 participants
@sighingnow @qinxuye @acezen