-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental Dask-on-Mars support #2289
Conversation
We don't have the habit to use sort of |
What's more, you can create a separate CI test in platform-ci, refer to https://github.com/mars-project/mars/blob/master/.github/workflows/platform-ci.yml to add a new ci in which dask installed. |
I am not familiar with CI tests, will this works? |
Seems dask test timeout. Could you please address the issue please? |
Working on that |
Is this PR ready for a review? maybe we could mark it as some milestone now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, coverage could be increased a bit.
Will |
Exposing I am working on doc |
Spelling check failed: https://github.com/mars-project/mars/pull/2289/checks?check_run_id=3342458497 |
Sorry about the typo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Congrats, look forward to seeing more contributions from you. |
What do these changes do?
Add experimental Dask-on-Mars support, which make it possible to run Dask collections on Mars.