Fix the error when multiple subtasks fetch the same data #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hekaisheng
added
type: bug
hekaisheng
force-pushed
the
bugfix/transfer
branch
2 times, most recently
from
8ed7a5f to
0399efc
Compare
hekaisheng
force-pushed
the
bugfix/transfer
branch
2 times, most recently
from
df8811a to
7539043
Compare
added 7 commits
August 12, 2021 14:09
… id" This reverts commit 83c5233
hekaisheng
force-pushed
the
bugfix/transfer
branch
from
00a6fa2 to
c9574b7
Compare
wjsi
requested changes
Aug 12, 2021
hekaisheng
force-pushed
the
bugfix/transfer
branch
5 times, most recently
from
af3c1f4 to
8a52695
Compare
hekaisheng
force-pushed
the
bugfix/transfer
branch
from
8a52695 to
b8606db
Compare
qinxuye
pushed a commit
that referenced
this pull request
Aug 16, 2021
qinxuye
added
backported already
chaokunyang
pushed a commit
to chaokunyang/mars
that referenced
this pull request
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When multiple subtasks fetch the same key at the same time, the transfer task may fails. In this PR,
ReceiverManagerActorholds a dict to record the data keys being fetched and create events to mark if transfer tasks are finished,SenderManagerActorwill wait those events to make sure all data keys are sent.Related issue number
Fixes #2321