Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives an error when input DataFrame has unknown dtypes #2355

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

qinxuye
Copy link
Collaborator

@qinxuye qinxuye commented Aug 19, 2021

What do these changes do?

This PR enables ability that gives an error when input DataFrame has unknown dtypes.

Related issue number

Fixes #2354 .

@qinxuye qinxuye added type: feature New feature mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Aug 19, 2021
@qinxuye qinxuye added this to the v0.8.0a2 milestone Aug 19, 2021
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 54b98a7 into mars-project:master Aug 19, 2021
@qinxuye qinxuye deleted the feature/unknown-dtypes-df branch August 19, 2021 13:39
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Aug 20, 2021
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Aug 20, 2021
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support DataFrame operations on data which generates unknown dtypes
3 participants