Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataFrame comparison when data type is period #2373

Merged
merged 6 commits into from
Aug 23, 2021

Conversation

qinxuye
Copy link
Collaborator

@qinxuye qinxuye commented Aug 23, 2021

What do these changes do?

This PR fixes DataFrame comparison when data type is period.

Related issue number

Fixes #2370 .

@qinxuye qinxuye added type: bug Something isn't working mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Aug 23, 2021
@qinxuye qinxuye added this to the v0.8.0a2 milestone Aug 23, 2021
@qinxuye qinxuye modified the milestones: v0.8.0a2, v0.8.0a3 Aug 23, 2021
@qinxuye qinxuye force-pushed the bugfix/df-comp-period branch from b11083a to ed6c0b5 Compare August 23, 2021 07:29
@qinxuye qinxuye force-pushed the bugfix/df-comp-period branch from ed6c0b5 to ebc7033 Compare August 23, 2021 07:33
@wjsi wjsi force-pushed the bugfix/df-comp-period branch 2 times, most recently from d7732ff to 7e20e87 Compare August 23, 2021 08:23
@wjsi wjsi force-pushed the bugfix/df-comp-period branch from 7e20e87 to 20ad748 Compare August 23, 2021 08:27
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 491f990 into mars-project:master Aug 23, 2021
@qinxuye qinxuye deleted the bugfix/df-comp-period branch August 23, 2021 09:51
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Aug 23, 2021
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported already PR has been backported mod: dataframe type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Arithmetic cannot process period type
3 participants