-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DataFrame comparison when data type is period #2373
Merged
hekaisheng
merged 6 commits into
mars-project:master
from
qinxuye:bugfix/df-comp-period
Aug 23, 2021
Merged
Fix DataFrame comparison when data type is period #2373
hekaisheng
merged 6 commits into
mars-project:master
from
qinxuye:bugfix/df-comp-period
Aug 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinxuye
added
type: bug
Something isn't working
mod: dataframe
to be backported
Indicate that the PR need to be backported to stable branch
labels
Aug 23, 2021
qinxuye
force-pushed
the
bugfix/df-comp-period
branch
from
August 23, 2021 07:29
b11083a
to
ed6c0b5
Compare
qinxuye
force-pushed
the
bugfix/df-comp-period
branch
from
August 23, 2021 07:33
ed6c0b5
to
ebc7033
Compare
wjsi
force-pushed
the
bugfix/df-comp-period
branch
2 times, most recently
from
August 23, 2021 08:23
d7732ff
to
7e20e87
Compare
wjsi
force-pushed
the
bugfix/df-comp-period
branch
from
August 23, 2021 08:27
7e20e87
to
20ad748
Compare
wjsi
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hekaisheng
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qinxuye
pushed a commit
to qinxuye/mars
that referenced
this pull request
Aug 23, 2021
(cherry picked from commit 491f990)
wjsi
pushed a commit
that referenced
this pull request
Aug 23, 2021
qinxuye
added
backported already
PR has been backported
and removed
to be backported
Indicate that the PR need to be backported to stable branch
labels
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR fixes DataFrame comparison when data type is period.
Related issue number
Fixes #2370 .