Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements fit and predict methods for bagging #2516

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Implements fit and predict methods for bagging #2516

merged 3 commits into from
Oct 19, 2021

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Oct 13, 2021 •
edited
Loading

What do these changes do?

Implements fit and predict methods for bagging.

Related issue number

Fixes part of #2495.

@wjsi wjsi added this to the v0.8.0rc1 milestone Oct 13, 2021
@wjsi wjsi force-pushed the feature/bagging branch 3 times, most recently from 2bb2f79 to 1add3e4 Compare October 15, 2021 08:29
@wjsi wjsi mentioned this pull request Oct 15, 2021
Merged
qinxuye
qinxuye reviewed Oct 19, 2021
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

mars/learn/ensemble/_bagging.py Show resolved Hide resolved
mars/learn/ensemble/_bagging.py Show resolved Hide resolved
qinxuye
qinxuye approved these changes Oct 19, 2021
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 3c67be0 into mars-project:master Oct 19, 2021
@wjsi wjsi deleted the feature/bagging branch October 19, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng hekaisheng approved these changes

Assignees
No one assigned
Labels
mod: learn type: feature New feature
Projects
None yet
Milestone
v0.8.0rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@wjsi @qinxuye @hekaisheng