Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display tileable properties on web #2525

Merged
merged 11 commits into from
Oct 22, 2021
Merged

Display tileable properties on web #2525

merged 11 commits into from
Oct 22, 2021

Conversation

RandomY-2
Copy link
Contributor

What do these changes do?

int/float/string type tileable properties are now displayed on the frontend

@qinxuye qinxuye added mod: web to be backported Indicate that the PR need to be backported to stable branch type: feature New feature labels Oct 15, 2021
@qinxuye qinxuye added this to the v0.8.0rc1 milestone Oct 15, 2021
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit 850ac56 into mars-project:master Oct 22, 2021
wjsi pushed a commit to wjsi/mars that referenced this pull request Oct 22, 2021
@qinxuye qinxuye removed the to be backported Indicate that the PR need to be backported to stable branch label Oct 22, 2021
@qinxuye qinxuye added the backported already PR has been backported label Oct 22, 2021
@RandomY-2 RandomY-2 deleted the mars branch May 13, 2022 15:44
@RandomY-2 RandomY-2 restored the mars branch May 13, 2022 15:44
@RandomY-2 RandomY-2 deleted the mars branch May 13, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported already PR has been backported mod: web type: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants