Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix df.loc when providing empty list #2528

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

qinxuye
Copy link
Collaborator

@qinxuye qinxuye commented Oct 15, 2021

What do these changes do?

Fix df.loc when providing empty list.

Related issue number

Fixes #2527

@qinxuye qinxuye added type: bug Something isn't working mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Oct 15, 2021
@qinxuye qinxuye added this to the v0.8.0rc1 milestone Oct 15, 2021
@qinxuye qinxuye added this to In progress in DataFrame via automation Oct 15, 2021
@qinxuye qinxuye added this to PR-In progress in v0.8 Release via automation Oct 15, 2021
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DataFrame automation moved this from In progress to Reviewer approved Oct 15, 2021
@hekaisheng hekaisheng merged commit d50d9f8 into mars-project:master Oct 15, 2021
DataFrame automation moved this from Reviewer approved to Done Oct 15, 2021
v0.8 Release automation moved this from PR-In progress to PR-Done Oct 15, 2021
@qinxuye qinxuye deleted the bugfix/df-loc branch October 15, 2021 09:44
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Oct 15, 2021
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported already PR has been backported mod: dataframe type: bug Something isn't working
Projects
DataFrame
  
Done
Development

Successfully merging this pull request may close these issues.

[BUG] df.loc failed when index is an empty list
3 participants