Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce indentation of frontend code #2540

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Reduce indentation of frontend code #2540

merged 1 commit into from
Oct 22, 2021

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Oct 22, 2021

What do these changes do?

Reduce indentation of frontend code to two spaces.

Related issue number

@wjsi wjsi added type: enhancement request mod: web to be backported Indicate that the PR need to be backported to stable branch labels Oct 22, 2021
@wjsi wjsi added this to the v0.8.0rc1 milestone Oct 22, 2021
@wjsi wjsi requested a review from qinxuye as a code owner October 22, 2021 03:35
qinxuye
qinxuye approved these changes Oct 22, 2021
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 3e049a3 into mars-project:master Oct 22, 2021
@wjsi wjsi deleted the enh/web_indent branch October 22, 2021 04:07
wjsi added a commit to wjsi/mars that referenced this pull request Oct 22, 2021
@wjsi
Reduce indentation of frontend code (mars-project#2540)
3a95fbe
@wjsi wjsi mentioned this pull request Oct 22, 2021
Merged
qinxuye pushed a commit that referenced this pull request Oct 22, 2021
@wjsi
[BACKPORT] Reduce indentation of frontend code (#2540) (#2541)
fc2e81b
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng hekaisheng approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: web type: enhancement request
Projects
None yet
Milestone
v0.8.0rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@wjsi @qinxuye @hekaisheng