Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement web API of get_infos #2558

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

fyrestone
Copy link
Contributor

What do these changes do?

Implement get_infos web api.

Related issue number

Closes #2555

@qinxuye qinxuye added the type: enhancement request label Oct 28, 2021
@qinxuye qinxuye added this to the v0.9.0a1 milestone Oct 28, 2021
@qinxuye qinxuye added the to be backported Indicate that the PR need to be backported to stable branch label Oct 28, 2021
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi changed the title Implement get_infos web api Implement web API of get_infos Oct 28, 2021
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 587b0ce into mars-project:master Oct 28, 2021
wjsi pushed a commit to wjsi/mars that referenced this pull request Oct 28, 2021
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AttributeError: 'WebStorageAPI' object has no attribute 'get_infos'
3 participants