Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests under cudf 21.10 #2574

Merged
merged 1 commit into from
Nov 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mars/dataframe/reduction/aggregation.py
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,12 @@ def _wrap_df(cls, op, value, index=None):
elif not isinstance(value, xdf.DataFrame):
new_index = None if not op.gpu else getattr(value, "index", None)
dtype = getattr(value, "dtype", None)
value = xdf.DataFrame(value, columns=index, index=new_index)
if xdf is pd:
value = xdf.DataFrame(value, columns=index, index=new_index)
else: # pragma: no cover
value = xdf.DataFrame(value)
value.index = new_index
value.columns = index
else:
return value

Expand Down
50 changes: 48 additions & 2 deletions mars/serialization/cuda.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

from typing import Any, List, Dict

import pandas as pd

from ..utils import lazy_import
from .core import Serializer, buffered

Expand Down Expand Up @@ -49,13 +51,57 @@ def deserialize(self, header: Dict, buffers: List, context: Dict):
class CudfSerializer(Serializer):
serializer_name = "cudf"

@staticmethod
def _get_ext_index_type(index_obj):
import cudf

multi_index_type = None
if isinstance(index_obj, pd.MultiIndex):
multi_index_type = "pandas"
elif isinstance(index_obj, cudf.MultiIndex):
multi_index_type = "cudf"

if multi_index_type is None:
return None
return {
"index_type": multi_index_type,
"names": list(index_obj.names),
}

@staticmethod
def _apply_index_type(obj, attr, header):
import cudf

multi_index_cls = (
pd.MultiIndex if header["index_type"] == "pandas" else cudf.MultiIndex
)
original_index = getattr(obj, attr)
if isinstance(original_index, (pd.MultiIndex, cudf.MultiIndex)):
return
new_index = multi_index_cls.from_tuples(original_index, names=header["names"])
setattr(obj, attr, new_index)

def serialize(self, obj: Any, context: Dict):
return obj.device_serialize()
header, buffers = obj.device_serialize()
if hasattr(obj, "columns"):
header["_ext_columns"] = self._get_ext_index_type(obj.columns)
if hasattr(obj, "index"):
header["_ext_index"] = self._get_ext_index_type(obj.index)
return header, buffers

def deserialize(self, header: Dict, buffers: List, context: Dict):
from cudf.core.abc import Serializable

return Serializable.device_deserialize(header, buffers)
col_header = header.pop("_ext_columns", None)
index_header = header.pop("_ext_index", None)

result = Serializable.device_deserialize(header, buffers)

if col_header is not None:
self._apply_index_type(result, "columns", col_header)
if index_header is not None:
self._apply_index_type(result, "index", index_header)
return result


if cupy is not None:
Expand Down
19 changes: 11 additions & 8 deletions mars/serialization/tests/test_serial.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,18 @@ def test_cupy(np_val):

@require_cudf
def test_cudf():
test_df = cudf.DataFrame(
pd.DataFrame(
{
"a": np.random.rand(1000),
"b": np.random.choice(list("abcd"), size=(1000,)),
"c": np.random.randint(0, 100, size=(1000,)),
}
)
raw_df = pd.DataFrame(
{
"a": np.random.rand(1000),
"b": np.random.choice(list("abcd"), size=(1000,)),
"c": np.random.randint(0, 100, size=(1000,)),
}
)
test_df = cudf.DataFrame(raw_df)
cudf.testing.assert_frame_equal(test_df, deserialize(*serialize(test_df)))

raw_df.columns = pd.MultiIndex.from_tuples([("a", "a"), ("a", "b"), ("b", "c")])
test_df = cudf.DataFrame(raw_df)
cudf.testing.assert_frame_equal(test_df, deserialize(*serialize(test_df)))


Expand Down