Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ray] Refine raydataset integration #2579

Merged
merged 6 commits into from
Nov 20, 2021
Merged

[ray] Refine raydataset integration #2579

merged 6 commits into from
Nov 20, 2021

Conversation

chaokunyang
Copy link
Contributor

What do these changes do?

Refine mars and ray dataset integration:

  • Refine to_ray_dataset/to_ray_mldataset implementation
  • Add MLDataset read operator
  • Add XGB integration test cases
  • Upgrade ray and xgb versions.

Related issue number

#2112

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@chaokunyang chaokunyang force-pushed the refine_raydataset_integration branch 3 times, most recently from 8a2dac8 to 049145f Compare November 17, 2021 08:25
wjsi
wjsi previously approved these changes Nov 18, 2021
View reviewed changes
@wjsi wjsi dismissed their stale review November 18, 2021 03:03

Checks

@chaokunyang chaokunyang force-pushed the refine_raydataset_integration branch from 049145f to 4e98319 Compare November 18, 2021 03:26
@chaokunyang chaokunyang force-pushed the refine_raydataset_integration branch from c3d0c07 to e44637e Compare November 18, 2021 09:23
wjsi
wjsi previously approved these changes Nov 19, 2021
View reviewed changes
qinxuye
qinxuye reviewed Nov 19, 2021
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some prints could be removed.

mars/dataframe/contrib/raydataset/tests/test_mldataset.py Outdated Show resolved Hide resolved
mars/dataframe/contrib/raydataset/tests/test_raydataset.py Outdated
reg = RayXGBRegressor(ray_params=ray_params, random_state=42)
# train
reg.fit(RayDMatrix(ds, "target"), y=None, ray_params=ray_params)
print(f"Regressor {reg}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

wjsi
wjsi approved these changes Nov 20, 2021
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qinxuye
qinxuye approved these changes Nov 20, 2021
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye added this to the v0.9.0a1 milestone Nov 20, 2021
@qinxuye qinxuye merged commit 7ad7e03 into mars-project:master Nov 20, 2021
@chaokunyang chaokunyang mentioned this pull request Feb 14, 2022
Open
@qinxuye qinxuye added the to be backported Indicate that the PR need to be backported to stable branch label Feb 15, 2022
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Feb 15, 2022
@chaokunyang
[Ray] Refine raydataset integration (mars-project#2579)
45fd953
@qinxuye qinxuye mentioned this pull request Feb 15, 2022
Merged
hekaisheng pushed a commit that referenced this pull request Feb 15, 2022
[BACKPORT][Ray] Refine raydataset integration (#2579) (#2712)
6c6fa9a
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjsi wjsi wjsi approved these changes

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng Awaiting requested review from hekaisheng

Assignees
No one assigned
Labels
backported already PR has been backported mod: dataframe mod: ray integration type: enhancement request
Projects
None yet
Milestone
v0.9.0a1
Development

Successfully merging this pull request may close these issues.
3 participants
@chaokunyang @qinxuye @wjsi