Reduce RPC cost of oscar by removing unnecessary tasks #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjsi
added
type: enhancement
wjsi
requested review from
chaokunyang,
fyrestone,
hekaisheng and
qinxuye
as code owners
hekaisheng
reviewed
Dec 7, 2021
chaokunyang
reviewed
Dec 8, 2021
| except asyncio.CancelledError: | ||
| try: | ||
| await self.cancel(address, message.message_id) | ||
| except CannotCancelTask: | ||
| # cancel failed, already finished | ||
| raise asyncio.CancelledError | ||
| except: # noqa: E722 # nosec # pylint: disable=bare-except | ||
| pass |
There was a problem hiding this comment.
Why ignore the exception？
There was a problem hiding this comment.
To make the result consistent with async.wait which does not raises. If any errors occur, await future will raise it.
wjsi
added a commit
to wjsi/mars
that referenced
this pull request
Dec 13, 2021
hekaisheng
pushed a commit
that referenced
this pull request
Dec 13, 2021
hekaisheng
added
backported already
chaokunyang
added a commit
to chaokunyang/mars
that referenced
this pull request
May 31, 2022
…ks (mars-project#2597) Merge branch cherry-pick-rpc-opt-mars-project#2597 of git@gitlab.alipay-inc.com:ray-project/mars.git into master https://code.alipay.com/ray-project/mars/pull_requests/217 Signed-off-by: 捕牛 <hejialing.hjl@antgroup.com> * Reduce RPC cost of oscar by removing unnecessary tasks (mars-project#2597) # Conflicts: # mars/deploy/oscar/session.py # mars/deploy/oscar/tests/test_local.py # mars/oscar/backends/pool.py # mars/oscar/backends/ray/communication.py # mars/services/scheduling/supervisor/assigner.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Reduce RPC cost of oscar by removing unnecessary tasks. Now Oscar can handle 4500 calls pser sec instead of 2500 before optimization.
Related issue number
Fixes #xxxx
Check code requirements