-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use batched request to apply for slots #2601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjsi
added
mod: scheduling service
to be backported
Indicate that the PR need to be backported to stable branch
type: enhancement
request
labels
Dec 3, 2021
wjsi
force-pushed
the
enh/batch_apply_slots
branch
from
December 6, 2021 03:38
067c33e
to
d96ef01
Compare
wjsi
force-pushed
the
enh/batch_apply_slots
branch
from
December 6, 2021 05:15
d96ef01
to
dcc75b0
Compare
hekaisheng
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qinxuye
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wjsi
added a commit
to wjsi/mars
that referenced
this pull request
Dec 13, 2021
hekaisheng
pushed a commit
that referenced
this pull request
Dec 13, 2021
hekaisheng
added
backported already
PR has been backported
and removed
to be backported
Indicate that the PR need to be backported to stable branch
labels
Dec 13, 2021
chaokunyang
added a commit
to chaokunyang/mars
that referenced
this pull request
May 31, 2022
…#2601) Merge branch cherry-pick-batch-apply-slots of git@gitlab.alipay-inc.com:ray-project/mars.git into master https://code.alipay.com/ray-project/mars/pull_requests/216 Signed-off-by: 留宝 <po.lb@antgroup.com> * Use batched request to apply for slots (mars-project#2601) # Conflicts: # mars/services/scheduling/supervisor/globalslot.py # mars/services/scheduling/supervisor/queueing.py # mars/services/scheduling/supervisor/tests/test_queue_balance.py # mars/services/scheduling/supervisor/tests/test_queueing.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Request global slots in batches. This reduces potential time cost when a number of slots are to be allocated.
Related issue number
Fixes #xxxx
Check code requirements