Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize eval-setitem expressions as single eval expressions #2695

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Feb 10, 2022

What do these changes do?

Optimize eval-setitem expressions as single eval expressions to reduce tileables.

Related issue number

Fixes #2694

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added type: enhancement request to be backported Indicate that the PR need to be backported to stable branch mod: optimization labels Feb 10, 2022
@wjsi wjsi added this to the v0.9.0b1 milestone Feb 10, 2022
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 45eeb8d into mars-project:master Feb 10, 2022
@wjsi wjsi deleted the enh/setitem_eval branch February 10, 2022 11:07
@hekaisheng hekaisheng added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame setitem can be optimized when expression is on the same DataFrame
3 participants