Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use_arrow_dtype parameter for read_parquet #2698

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

hekaisheng
Copy link
Contributor

What do these changes do?

Make use_arrow_dtype=True work well for reading directory path for read_parquet.

Related issue number

Fixes #2697

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@hekaisheng hekaisheng added type: bug Something isn't working mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Feb 10, 2022
@hekaisheng hekaisheng added this to the v0.9.0b1 milestone Feb 10, 2022
if use_arrow_dtype is None:
use_arrow_dtype = options.dataframe.use_arrow_dtype
if use_arrow_dtype:
dtypes = to_arrow_dtypes(dtypes)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check why this line is not covered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems covered from codecov

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit c7d2bfb into mars-project:master Feb 10, 2022
hekaisheng added a commit to hekaisheng/mars that referenced this pull request Feb 11, 2022
wjsi pushed a commit that referenced this pull request Feb 11, 2022
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Feb 11, 2022
@hekaisheng hekaisheng deleted the bugfix/read-parquet branch March 11, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported already PR has been backported mod: dataframe type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] use_arrow_dtype doesn't work when read a directory path for read_parquet
3 participants