[Ray] Ray client channel get recv when first complied #2740
Conversation
Merge branch fix_channel_hang of git@gitlab.alipay-inc.com:ray-project/mars.git into master https://code.alipay.com/ray-project/mars/pull_requests/36 Signed-off-by: 慕白 <chaokun.yck@antgroup.com> * fix hang * revert * fix import error
Catch-Bull
requested review from
chaokunyang,
fyrestone and
qinxuye
as code owners
|
We use the latest version of black(22.1.0) to format the code, could you please format your code first? |
sure! |
qinxuye
changed the title
|
@chaokunyang @fyrestone This PR seems ready to review, could u plz take a look at it? |
| self._todo.remove(future) | ||
| self._done.put_nowait(future) | ||
|
|
||
| future = asyncio.ensure_future(handle_task(message, object_ref)) |
There was a problem hiding this comment.
ensure_future will create an asyncio.Task, which may have some cost. Wonder whether we should use direct ray call for ray channel, like we did in #2690
|
Since #2690 break the abstraction of oscar actor pool, and is not merged until now, I think we can merge this first, and discuss whether we should use dirsct call in #2690. @Catch-Bull @qinxuye @wjsi Any ideas? |
As now intra-process actor calls are made into direct calls, and #2690 still a WIP (also seems not a very huge PR), personally I would like to merge right now. Try resolving conflicts and rerun checks. |
…plied # Conflicts: # mars/oscar/backends/ray/communication.py
What do these changes do?
Ray client channel get return of function
recvwhen first complied, This PR can improve efficiency and avoid some potential hang risksRelated issue number
Fixes #xxxx
Check code requirements