-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metric] Add metric framework #2742
[Metric] Add metric framework #2742
Conversation
3aad232
to
6aed99d
Compare
According to the checks: https://dev.azure.com/mars-project/mars/_build/results?buildId=2423&view=logs&jobId=435ca956-9126-505f-566f-fff31072e2ba&j=435ca956-9126-505f-566f-fff31072e2ba&t=b177376e-c888-527f-c765-631942cc7432 , please use relative import instead of absolute import. |
Thanks a lot. I'll fix it. |
18ac68c
to
ae62107
Compare
* Use relative import instead of absolute import of `test_metric_api.py` * Add metric test config in pipelines * Add more tests
ae62107
to
fa94f6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, I add some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What do these changes do?
There is no metrics in mars and it's useful and necessary to add a simple and convenient metric framework.
Related issue number
Issuse #2743
Check code requirements