Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profiling band_subtasks and most_calls are empty if the slow duration is large #2755

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Fix profiling band_subtasks and most_calls are empty if the slow duration is large #2755

merged 3 commits into from
Feb 25, 2022

Conversation

fyrestone
Copy link
Contributor

What do these changes do?

  • Fix band_subtasks and most_calls are empty if the slow duration is large

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@fyrestone fyrestone self-assigned this Feb 25, 2022
@fyrestone fyrestone changed the title Fix band_subtasks and most_calls are empty if the slow duration is large Fix profiling band_subtasks and most_calls are empty if the slow duration is large Feb 25, 2022
@qinxuye qinxuye added mod: actor type: bug Something isn't working labels Feb 25, 2022
wjsi
wjsi approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye added this to the v0.9.0b2 milestone Feb 25, 2022
qinxuye
qinxuye approved these changes Feb 25, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 300f9bb into mars-project:master Feb 25, 2022
@qinxuye qinxuye mentioned this pull request Feb 25, 2022
Closed
qinxuye pushed a commit to hekaisheng/mars that referenced this pull request Mar 1, 2022
@fyrestone
Fix profiling band_subtasks and most_calls are empty if the slow dura…
8f2cb6f 
…tion is large (mars-project#2755)
chaokunyang pushed a commit to chaokunyang/mars that referenced this pull request May 31, 2022
PullRequest: 267 [CP from github] 2748 2755 2801
5dca9c8 
Merge branch cp_2748_2755_2801 of git@gitlab.alipay-inc.com:ray-project/mars.git into master
https://code.alipay.com/ray-project/mars/pull_requests/267

Signed-off-by: 不涸 <zhongchun.yzc@antgroup.com>


* Fix long exception of asyncio.gather (mars-project#2748)

* Fix profiling band_subtasks and most_calls are empty if the slow duration is large (mars-project#2755)

* [Ray] Default enable fault tolerance for ray (mars-project#2801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjsi wjsi wjsi approved these changes

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng Awaiting requested review from hekaisheng

Assignees

@fyrestone fyrestone

Labels
mod: actor type: bug Something isn't working
Projects
None yet
Milestone
v0.9.0b2
Development

Successfully merging this pull request may close these issues.
3 participants
@fyrestone @qinxuye @wjsi