Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop inferring outputs when args provided #2759

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Stop inferring outputs when args provided #2759

merged 1 commit into from
Feb 28, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Feb 27, 2022

What do these changes do?

Stop inferring outputs when args provided

Related issue number

Fixes #2758

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added type: enhancement request mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Feb 27, 2022
@wjsi wjsi added this to the v0.9.0b2 milestone Feb 27, 2022
@wjsi wjsi force-pushed the enh/no_infer_when_provide branch 2 times, most recently from 7e26a11 to 5a96496 Compare February 28, 2022 02:57
@wjsi wjsi force-pushed the enh/no_infer_when_provide branch from 5a96496 to c487bb6 Compare February 28, 2022 04:15
qinxuye
qinxuye approved these changes Feb 28, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 0c3d18a into mars-project:master Feb 28, 2022
wjsi added a commit to wjsi/mars that referenced this pull request Feb 28, 2022
@wjsi
Stop inferring outputs when args provided (mars-project#2759)
c78035a
@wjsi wjsi mentioned this pull request Feb 28, 2022
Merged
@wjsi wjsi deleted the enh/no_infer_when_provide branch February 28, 2022 07:19
qinxuye pushed a commit that referenced this pull request Feb 28, 2022
@wjsi
[BACKPORT] Stop inferring outputs when args provided (#2759) (#2761)
1318ed0
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Feb 28, 2022
qinxuye pushed a commit to hekaisheng/mars that referenced this pull request Mar 1, 2022
@wjsi
Stop inferring outputs when args provided (mars-project#2759)
95c1fe1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hekaisheng hekaisheng hekaisheng approved these changes

@qinxuye qinxuye qinxuye approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: dataframe type: enhancement request
Projects
None yet
Milestone
v0.9.0b2
Development

Successfully merging this pull request may close these issues.

make mars type inference optional
3 participants
@wjsi @qinxuye @hekaisheng