Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DataFrame initializer when Mars object exists in list #2770

Merged
merged 6 commits into from
Mar 2, 2022
Merged

Fix DataFrame initializer when Mars object exists in list #2770

merged 6 commits into from
Mar 2, 2022

Conversation

qinxuye
Copy link
Collaborator

@qinxuye qinxuye commented Mar 1, 2022

What do these changes do?

This PR fixes DataFrame initializer when Mars object exists in list

Related issue number

Fixes #2769

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@qinxuye qinxuye added type: bug Something isn't working mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Mar 1, 2022
@qinxuye qinxuye added this to the v0.9.0b2 milestone Mar 1, 2022
@qinxuye qinxuye requested review from wjsi and hekaisheng as code owners March 1, 2022 08:10
@qinxuye qinxuye requested a review from sighingnow as a code owner March 1, 2022 09:37
sighingnow
sighingnow previously approved these changes Mar 1, 2022
View reviewed changes
@qinxuye
Copy link
Collaborator Author

qinxuye commented Mar 2, 2022

This PR is ready for review, @wjsi @hekaisheng @sighingnow

wjsi
wjsi approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit f732c77 into mars-project:master Mar 2, 2022
@qinxuye qinxuye deleted the enh/from-tensor branch March 2, 2022 10:33
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Mar 2, 2022
Fix DataFrame initializer when Mars object exists in list (mars-proje…
8f2bb05 
…ct#2770)

(cherry picked from commit f732c77)
@qinxuye qinxuye mentioned this pull request Mar 2, 2022
Merged
wjsi pushed a commit that referenced this pull request Mar 3, 2022
[BACKPORT] Fix DataFrame initializer when Mars object exists in list (#…
3a9c4e4 
…2770) (#2778)
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hekaisheng hekaisheng hekaisheng approved these changes

@wjsi wjsi wjsi approved these changes

@sighingnow sighingnow sighingnow approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: dataframe type: bug Something isn't working
Projects
None yet
Milestone
v0.9.0b2
Development

Successfully merging this pull request may close these issues.

[BUG] Failed to create Mars DataFrame when mars object exists in a list
4 participants
@qinxuye @sighingnow @wjsi @hekaisheng