Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broadcast merge support for DataFrame #2772

Merged
merged 8 commits into from
Mar 4, 2022

Conversation

hekaisheng
Copy link
Contributor

@hekaisheng hekaisheng commented Mar 1, 2022

What do these changes do?

This PR implements a broadcast join method for DataFrames, when small DataFrame's chunk size is far less than bigger one, only shuffle the small one and broadcast them to the chunks of the other DataFrame, it will reduce time cost by avoiding shuffle of big DataFrame.

Related issue number

Check code requirements

@hekaisheng hekaisheng added this to the v0.9.0b2 milestone Mar 1, 2022
@hekaisheng hekaisheng requested review from qinxuye and wjsi as code owners March 1, 2022 09:38
@hekaisheng hekaisheng marked this pull request as draft March 1, 2022 09:39
sighingnow
sighingnow previously approved these changes Mar 2, 2022
@hekaisheng
Copy link
Contributor Author

Ready to review now.

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.

mars/dataframe/merge/merge.py Outdated Show resolved Hide resolved
mars/dataframe/merge/merge.py Outdated Show resolved Hide resolved
mars/dataframe/merge/merge.py Outdated Show resolved Hide resolved
mars/dataframe/merge/merge.py Outdated Show resolved Hide resolved
mars/dataframe/merge/merge.py Outdated Show resolved Hide resolved
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit ca51e67 into mars-project:master Mar 4, 2022
@qinxuye qinxuye deleted the enh/merge branch March 4, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants