Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ray] support ray client mode #2773

Merged
merged 10 commits into from
Mar 8, 2022

Conversation

chaokunyang
Copy link
Contributor

@chaokunyang chaokunyang commented Mar 1, 2022

What do these changes do?

Support ray client mode for mars on ray

Related issue number

Fixes #2762
Fixes #2768

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@qinxuye
Copy link
Collaborator

qinxuye commented Mar 1, 2022

#2768 seems another ray client use case, can it be fixed by this PR as well?

@qinxuye qinxuye added mod: ray integration to be backported Indicate that the PR need to be backported to stable branch type: bug Something isn't working labels Mar 2, 2022
@qinxuye qinxuye added this to the v0.9.0b2 milestone Mar 2, 2022
@chaokunyang chaokunyang changed the title [ray] fix ray client mode [ray] support ray client mode Mar 2, 2022
@chaokunyang
Copy link
Contributor Author

#2768 seems another ray client use case, can it be fixed by this PR as well?

It's also fixed in this PR.

@chaokunyang chaokunyang force-pushed the fix_ray_client_serialization branch from 61e9f3c to 4474103 Compare March 2, 2022 04:27
@chaokunyang chaokunyang force-pushed the fix_ray_client_serialization branch 2 times, most recently from 6d9d06a to 0333666 Compare March 4, 2022 07:59
@chaokunyang chaokunyang force-pushed the fix_ray_client_serialization branch from fede812 to f9a32be Compare March 7, 2022 04:25
@chaokunyang chaokunyang force-pushed the fix_ray_client_serialization branch from a4f5c27 to 8f16154 Compare March 7, 2022 15:42
@chaokunyang chaokunyang force-pushed the fix_ray_client_serialization branch from 8f16154 to 218c4b1 Compare March 8, 2022 02:46
…ization

# Conflicts:
#	mars/deploy/oscar/tests/test_ray.py
#	mars/oscar/backends/ray/pool.py
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit 9b3cc49 into mars-project:master Mar 8, 2022
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Mar 8, 2022
wjsi pushed a commit that referenced this pull request Mar 8, 2022
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported already PR has been backported mod: ray integration type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Block When exec df2.head [BUG]mars.new_ray_session error
3 participants