-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ray] New ray actor creation model #2783
Merged
wjsi
merged 11 commits into
mars-project:master
from
chaokunyang:new_ray_actor_creation_model
Mar 8, 2022
Merged
[ray] New ray actor creation model #2783
wjsi
merged 11 commits into
mars-project:master
from
chaokunyang:new_ray_actor_creation_model
Mar 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch refine_subpool_check_mainpool_alive of git@gitlab.alipay-inc.com:ray-project/mars.git into master https://code.alipay.com/ray-project/mars/pull_requests/185 Signed-off-by: 天苍 <yiming.yym@antgroup.com> Signed-off-by: 不涸 <zhongchun.yzc@antgroup.com> * refine subpool keep alive logic
chaokunyang
requested review from
fyrestone,
qinxuye,
wjsi and
hekaisheng
as code owners
March 3, 2022 12:05
chaokunyang
force-pushed
the
new_ray_actor_creation_model
branch
from
March 3, 2022 12:08
0b33b00
to
49ea0dc
Compare
Could you please try to increase the coverage a bit? |
qinxuye
added
mod: ray integration
type: enhancement
request
to be backported
Indicate that the PR need to be backported to stable branch
labels
Mar 6, 2022
chaokunyang
force-pushed
the
new_ray_actor_creation_model
branch
from
March 7, 2022 09:20
6d72030
to
504276a
Compare
Branch conflicts, please resolve it. |
…n_model # Conflicts: # mars/deploy/oscar/ray.py
qinxuye
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wjsi
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qinxuye
pushed a commit
to qinxuye/mars
that referenced
this pull request
Mar 8, 2022
(cherry picked from commit f4aed31)
wjsi
pushed a commit
that referenced
this pull request
Mar 8, 2022
qinxuye
added
backported already
PR has been backported
and removed
to be backported
Indicate that the PR need to be backported to stable branch
labels
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
Fixes #2782
Check code requirements