Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ray] New ray actor creation model #2783

Merged
merged 11 commits into from
Mar 8, 2022

Conversation

chaokunyang
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #2782

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

chaokunyang and others added 5 commits March 3, 2022 17:35
Merge branch refine_subpool_check_mainpool_alive of git@gitlab.alipay-inc.com:ray-project/mars.git into master
https://code.alipay.com/ray-project/mars/pull_requests/185

Signed-off-by: 天苍 <yiming.yym@antgroup.com>
Signed-off-by: 不涸 <zhongchun.yzc@antgroup.com>


* refine subpool keep alive logic
@chaokunyang chaokunyang force-pushed the new_ray_actor_creation_model branch from 0b33b00 to 49ea0dc Compare March 3, 2022 12:08
@qinxuye
Copy link
Collaborator

qinxuye commented Mar 6, 2022

Could you please try to increase the coverage a bit?

@qinxuye qinxuye added mod: ray integration type: enhancement request to be backported Indicate that the PR need to be backported to stable branch labels Mar 6, 2022
@qinxuye qinxuye added this to the v0.9.0b2 milestone Mar 6, 2022
@chaokunyang chaokunyang force-pushed the new_ray_actor_creation_model branch from 6d72030 to 504276a Compare March 7, 2022 09:20
@qinxuye
Copy link
Collaborator

qinxuye commented Mar 7, 2022

Branch conflicts, please resolve it.

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit f4aed31 into mars-project:master Mar 8, 2022
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Mar 8, 2022
wjsi pushed a commit that referenced this pull request Mar 8, 2022
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ray] new worker create model
3 participants