Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid printing too many messages in Oscar #2871

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Avoid printing too many messages in Oscar #2871

merged 1 commit into from
Mar 25, 2022

Conversation

chaokunyang
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #2870

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@chaokunyang
Copy link
Contributor Author

I hardcode the truncate length to 500, seems it's not necesssary to make it as an constant

@qinxuye qinxuye changed the title avoid print too many messages. Avoid print too many messages. Mar 25, 2022
@qinxuye qinxuye added type: enhancement request mod: actor to be backported Indicate that the PR need to be backported to stable branch labels Mar 25, 2022
@qinxuye qinxuye added this to the v0.9.0rc2 milestone Mar 25, 2022
@wjsi wjsi changed the title Avoid print too many messages. Avoid printing too many messages in Oscar Mar 25, 2022
wjsi
wjsi approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qinxuye
qinxuye approved these changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 674cdf2 into mars-project:master Mar 25, 2022
wjsi pushed a commit to wjsi/mars that referenced this pull request Mar 28, 2022
@chaokunyang @wjsi
Avoid printing too many messages in Oscar (mars-project#2871)
2cf546f
@wjsi wjsi mentioned this pull request Mar 28, 2022
Merged
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjsi wjsi wjsi approved these changes

@qinxuye qinxuye qinxuye approved these changes

@fyrestone fyrestone Awaiting requested review from fyrestone

Assignees
No one assigned
Labels
backported already PR has been backported mod: actor type: enhancement request
Projects
None yet
Milestone
v0.9.0rc2
Development

Successfully merging this pull request may close these issues.

[BUG] Mars produces messages too long to open inside an editor
3 participants
@chaokunyang @qinxuye @wjsi