Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure error can be raised in Actor.__pre_destroy__ #2887

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Make sure error can be raised in Actor.__pre_destroy__ #2887

merged 3 commits into from
Mar 31, 2022

Conversation

qinxuye
Copy link
Collaborator

@qinxuye qinxuye commented Mar 30, 2022

What do these changes do?

This PR Add ability to make sure error can be raised in Actor.__pre_destroy__.

Related issue number

Fixes #2885 .

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@qinxuye qinxuye added type: bug Something isn't working mod: actor to be backported Indicate that the PR need to be backported to stable branch labels Mar 30, 2022
@qinxuye qinxuye added this to the v0.9.0rc2 milestone Mar 30, 2022
@qinxuye qinxuye force-pushed the bugfix/error_pre_destroy branch 4 times, most recently from 8bceb94 to 3099dba Compare March 31, 2022 08:18
@qinxuye qinxuye marked this pull request as ready for review March 31, 2022 08:59
@qinxuye qinxuye requested review from hekaisheng and wjsi as code owners March 31, 2022 08:59
@qinxuye qinxuye force-pushed the bugfix/error_pre_destroy branch from 3099dba to 7b7b901 Compare March 31, 2022 09:37
hekaisheng
hekaisheng approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wjsi
wjsi approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit 75e1c88 into mars-project:master Mar 31, 2022
@qinxuye qinxuye deleted the bugfix/error_pre_destroy branch March 31, 2022 12:25
wjsi pushed a commit to wjsi/mars that referenced this pull request Apr 1, 2022
@wjsi
Make sure errors can be raised in Actor.__pre_destroy__ (mars-proje…
6faccee 
…ct#2887)
@wjsi wjsi mentioned this pull request Apr 1, 2022
Merged
qinxuye pushed a commit that referenced this pull request Apr 1, 2022
@wjsi
[BACKPORT] Make sure errors can be raised in Actor.__pre_destroy__ (#…
2152931 
…2887) (#2892)
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hekaisheng hekaisheng hekaisheng approved these changes

@wjsi wjsi wjsi approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: actor type: bug Something isn't working
Projects
None yet
Milestone
v0.9.0rc2
Development

Successfully merging this pull request may close these issues.

[BUG] Error is just ignored in Actor.__pre_destroy__
3 participants
@qinxuye @wjsi @hekaisheng