Stop recording all mapper meta #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinxuye
added
type: enhancement
qinxuye
force-pushed
the
enh/shuffle
branch
2 times, most recently
from
1228e9a to
eb0b931
Compare
4 tasks
qinxuye
removed
the
to be backported
|
Too much difference exists between 0.8 and master, thus not gotta be backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR rolls back the logic in #2248 that all mapper meta are stored in meta service, storage can correctly remove all data given main keys only.
Related issue number
Fixes #2896
Fixes #2899
Check code requirements