-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Ray execution backend #2921
Merged
hekaisheng
merged 40 commits into
mars-project:master
from
fyrestone:basic_ray_execution_backend
Apr 24, 2022
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
245f49d
Basic ray execution backend
f250ee3
Fix lint
b20748d
Merge remote-tracking branch 'upstream/master' into basic_ray_executi…
8fbab7c
Refine ExecutionAPI to support meta updating optimization #2912
af2c436
Merge remote-tracking branch 'upstream/master' into basic_ray_executi…
d1a448b
Fix
63e3e67
Fix
0d54f8c
Fix
d92f380
Merge remote-tracking branch 'upstream/master' into basic_ray_executi…
4396c14
Refine code
c5e78a6
Fix no bands info for ray execution backend
5991ef3
Fix
6e10497
Fix
6a53b23
Pin xgboost<1.6.0 to avoid breaking API
0282838
Fix
9e1d91a
Remove debug code
a4193a4
Merge remote-tracking branch 'upstream/master' into basic_ray_executi…
451492b
Ensure coverage for ray execution backend.
f93e243
Fix
8d4db20
Refine Fetcher
5bebe14
Fix
41b464a
Fix
0411cd9
Refine session backend
3573204
Fix
d29ace9
Fix
4a101e7
Fix lint
704e036
Fix
d986d6e
Merge remote-tracking branch 'upstream/master' into basic_ray_executi…
b7f2c27
Debug CI
60a221e
Revert "Debug CI"
5717858
Improve test session
2247695
Debug CI
6a1f0ff
Fix lint
2bb9d14
Debug CI2
edf6616
Try to Fix CI
e4b2587
Revert "Debug CI2"
6c79007
Revert "Debug CI"
091f4e0
Fix CI
f5e8d44
Improve coverage
76316da
Fix CI
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
mars/deploy/oscar/tests/local_test_with_ray_dag_config.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
"@inherits": '@default' | ||
session: | ||
custom_log_dir: auto | ||
plasma: | ||
store_memory: 32M | ||
scheduling: | ||
mem_hard_limit: 0 | ||
task: | ||
task_executor_config: | ||
"backend": "ray" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's weird to see the
backend
here actually takes no effect, both Mars & ray pass the backend with valueoscar
, I wonder if we can unify thebackend
andexecution_backend
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, We can resuse the backend for ray execution backend? e.g.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just name mars for mars, ray for mars on ray?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, the
backend
is bound to the session cls. The execution backend only for the execution implementation. I am not sure if it is a good idea to mix them to one.Currenty,
I can mix them to one,
The backend will never bounds to the session cls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's ok, backend for different backend not for session cls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will push a commit to fix this. Thanks.