Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cython to accelerate core serialization #2924

Merged
merged 3 commits into from
Apr 18, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Apr 16, 2022

What do these changes do?

Use cython to accelerate core serialization. Generate usage is eliminated to ensure fast enumeration over the data structure. Also change core serialization format from dicts into tuples to reduce serialization result.

Benchmark:

image

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added this to the v0.9.0rc3 milestone Apr 16, 2022
@wjsi wjsi force-pushed the enh/pickle_serial branch from 3257e82 to 2ff24bd Compare April 16, 2022 16:15
@wjsi wjsi force-pushed the enh/pickle_serial branch from 2ff24bd to fe007d3 Compare April 16, 2022 16:43
@wjsi wjsi force-pushed the enh/pickle_serial branch from eda0411 to ee98bb9 Compare April 17, 2022 06:30
@wjsi wjsi marked this pull request as ready for review April 17, 2022 06:30
@wjsi wjsi requested review from hekaisheng and qinxuye as code owners April 17, 2022 06:30
@wjsi wjsi force-pushed the enh/pickle_serial branch from ee98bb9 to eff32bc Compare April 17, 2022 06:33
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit e873d77 into mars-project:master Apr 18, 2022
@wjsi wjsi deleted the enh/pickle_serial branch April 18, 2022 07:24
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Apr 21, 2022
wjsi added a commit to wjsi/mars that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants