Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine lifecycle api to support incref or decref with ref counts #2926

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

qinxuye
Copy link
Collaborator

@qinxuye qinxuye commented Apr 18, 2022

What do these changes do?

This PR refines lifecycle api to support incref or decref with ref counts.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@qinxuye qinxuye force-pushed the enh/lifecycle-api branch from fc4aaa8 to a78d532 Compare April 18, 2022 07:27
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit b51afae into mars-project:master Apr 18, 2022
@qinxuye qinxuye deleted the enh/lifecycle-api branch April 18, 2022 09:22
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Apr 21, 2022
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants