Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spawning serialization to threads for large objects #2944

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Apr 20, 2022

What do these changes do?

Allow spawning serialization to threads for large objects. When the number of objects is larger than certain threshold, serializing will be moved into a ThreadPoolExecutor.

Related issue number

Fixes #2942

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added this to the v0.9.0rc3 milestone Apr 20, 2022
@wjsi wjsi requested review from qinxuye and hekaisheng as code owners April 20, 2022 14:51
@wjsi wjsi force-pushed the enh/ser_thresh branch 2 times, most recently from 01360d0 to 0a07b42 Compare April 21, 2022 04:56
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit a73970b into mars-project:master Apr 21, 2022
@wjsi wjsi deleted the enh/ser_thresh branch April 21, 2022 07:06
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Apr 21, 2022
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supports spawning heavy serialization to threads
3 participants