Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sort=True for Groupby #2959

Merged
merged 35 commits into from
May 13, 2022
Merged

Support sort=True for Groupby #2959

merged 35 commits into from
May 13, 2022

Conversation

sak2002
Copy link
Contributor

@sak2002 sak2002 commented Apr 25, 2022 •
edited
Loading

What do these changes do?

Related issue number

Fixes #2915

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi marked this pull request as draft May 6, 2022 00:43
@qinxuye qinxuye added this to the v0.9.0rc3 milestone May 6, 2022
@qinxuye qinxuye changed the title [DO NOT MERGE] Dev/groupby sort poc [DO NOT MERGE] Support sort=True for Groupby May 6, 2022
@qinxuye qinxuye removed this from the v0.9.0rc3 milestone May 7, 2022
@sak2002 sak2002 changed the title [DO NOT MERGE] Support sort=True for Groupby Support sort=True for Groupby May 8, 2022
@qinxuye qinxuye marked this pull request as ready for review May 9, 2022 03:04
qinxuye
qinxuye reviewed May 9, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work, LGTM overall, some comments are mainly about type hints and code style.

mars/dataframe/groupby/aggregation.py Outdated Show resolved Hide resolved
mars/dataframe/groupby/aggregation.py Outdated Show resolved Hide resolved
mars/dataframe/groupby/aggregation.py Outdated Show resolved Hide resolved
mars/dataframe/groupby/sort.py Outdated Show resolved Hide resolved
mars/dataframe/groupby/sort.py Outdated Show resolved Hide resolved
@qinxuye qinxuye added this to the v0.10.0a1 milestone May 13, 2022
hekaisheng
hekaisheng approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really a great work.

wjsi
wjsi approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qinxuye
qinxuye approved these changes May 13, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 3adefad into mars-project:master May 13, 2022
@qinxuye
Copy link
Collaborator

qinxuye commented May 13, 2022

Really nice work.

@wjsi wjsi mentioned this pull request May 13, 2022
Open
8 tasks
@qinxuye qinxuye added the to be backported Indicate that the PR need to be backported to stable branch label May 13, 2022
wjsi pushed a commit to wjsi/mars that referenced this pull request May 23, 2022
@sak2002 @sakshamkumar-byt @wjsi
Support sort=True for Groupby (mars-project#2959)
20b88ca 
Co-authored-by: Saksham Kumar <saksham.kumar@bytedance.com>
Co-authored-by: 继盛 <xuye.qin@alibaba-inc.com>
@wjsi wjsi mentioned this pull request May 23, 2022
Merged
qinxuye pushed a commit that referenced this pull request May 23, 2022
@wjsi
[BACKPORT] Support sort=True for Groupby (#2959) (#3063)
f95ea23
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hekaisheng hekaisheng hekaisheng approved these changes

@wjsi wjsi wjsi approved these changes

@qinxuye qinxuye qinxuye approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: dataframe type: feature New feature
Projects
None yet
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.

Proposal - Group By Sort
5 participants
@sak2002 @qinxuye @wjsi @hekaisheng @sakshamkumar-byt