Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable bloom filter in merge for now #2967

Merged
merged 2 commits into from
May 9, 2022
Merged

Disable bloom filter in merge for now #2967

merged 2 commits into from
May 9, 2022

Conversation

qinxuye
Copy link
Collaborator

@qinxuye qinxuye commented Apr 26, 2022 •
edited
Loading

What do these changes do?

This PR disabled bloom filter in merge for now unless it's forced set to True. When the bloom filter is optimized enough, it can be turned on then.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@qinxuye qinxuye added this to the v0.9.0rc3 milestone Apr 26, 2022
@qinxuye qinxuye requested a review from hekaisheng as a code owner April 26, 2022 08:59
@qinxuye qinxuye requested a review from wjsi as a code owner April 26, 2022 08:59
@qinxuye qinxuye marked this pull request as draft April 26, 2022 09:50
@qinxuye qinxuye changed the title Support bloom filtering on both sides of md.merge Optimize bloom filter for md.merge Apr 27, 2022
@qinxuye qinxuye changed the title Optimize bloom filter for md.merge Support more configuration for bloom filter when calling md.merge Apr 28, 2022
@qinxuye qinxuye force-pushed the enh/df-merge branch 3 times, most recently from b313842 to 0a0b196 Compare May 5, 2022 03:25
@qinxuye qinxuye removed this from the v0.9.0rc3 milestone May 6, 2022
@qinxuye qinxuye changed the title Support more configuration for bloom filter when calling md.merge Disable bloom filter in merge for now May 7, 2022
@qinxuye qinxuye added this to the v0.9.0rc3 milestone May 7, 2022
@qinxuye qinxuye marked this pull request as ready for review May 7, 2022 12:05
@qinxuye qinxuye modified the milestones: v0.9.0rc3, v0.10.0a1 May 7, 2022
@qinxuye qinxuye added the to be backported Indicate that the PR need to be backported to stable branch label May 8, 2022
@qinxuye
Copy link
Collaborator Author

qinxuye commented May 8, 2022

This PR is ready for review.

hekaisheng
hekaisheng approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wjsi
wjsi approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit 4d64416 into mars-project:master May 9, 2022
@qinxuye qinxuye deleted the enh/df-merge branch May 9, 2022 08:37
qinxuye pushed a commit to qinxuye/mars that referenced this pull request May 23, 2022
Disable bloom filter in merge for now (mars-project#2967)
696d95e 
(cherry picked from commit 4d64416)
@qinxuye qinxuye mentioned this pull request May 23, 2022
Merged
wjsi pushed a commit that referenced this pull request May 23, 2022
[BACKPORT] Disable bloom filter in merge for now (#2967) (#3071)
40faabb
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hekaisheng hekaisheng hekaisheng approved these changes

@wjsi wjsi wjsi approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: dataframe type: enhancement request
Projects
None yet
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.
3 participants
@qinxuye @wjsi @hekaisheng