[Metrics] Optimize metric configs #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongchun
requested review from
wjsi,
qinxuye,
hekaisheng,
chaokunyang and
fyrestone
as code owners
chaokunyang
pushed a commit
to chaokunyang/mars
that referenced
this pull request
Jun 15, 2022
Merge branch cp-from-github-2996 of git@gitlab.alipay-inc.com:ray-project/mars.git into master https://code.alipay.com/ray-project/mars/pull_requests/303?tab=diff Signed-off-by: 慕白 <chaokun.yck@antgroup.com> * Optimize metric configs (mars-project#2996)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The arguments of
init_metrics(backend, port)method are inappropriate. Because port is a configuration of prometheus. It is not necessary forconsoleandray. It's better to change it toconfigand in this way we could easily add new metric backend.Related issue number
Fixes #xxxx
Check code requirements