Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing extra_params when constructing operands #2999

Merged
merged 2 commits into from
May 6, 2022
Merged

Fix missing extra_params when constructing operands #2999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c2c6bd
Fix missing extra_params when constructing operands
May 5, 2022
4181ddc
Add test
May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mars/core/operand/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,8 @@ def __init__(self: OperandType, *args, **kwargs):

@classmethod
def _parse_kwargs(cls, kwargs: Dict[str, Any]):
kwargs["extra_params"] = extras = AttributeDict()
extra_params = kwargs.pop("extra_params", {})
kwargs["extra_params"] = extras = AttributeDict(extra_params)
kwargs["scheduling_hint"] = scheduling_hint = kwargs.get(
"scheduling_hint", SchedulingHint()
)
Expand Down
2 changes: 2 additions & 0 deletions mars/core/operand/tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ class MyOperand5(MyOperand4):


def test_execute():
op = MyOperand(extra_params={"my_extra_params": 1})
assert op.extra_params["my_extra_params"] == 1
MyOperand.register_executor(lambda *_: 2)
assert execute(dict(), MyOperand(_key="1")) == 2
assert execute(dict(), MyOperand2(_key="1")) == 2
Expand Down