Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @pytest_asyncio.fixture instead of @pytest.fixture for async fixtures #3025

Merged
merged 1 commit into from
May 12, 2022
Merged

Use @pytest_asyncio.fixture instead of @pytest.fixture for async fixtures #3025

merged 1 commit into from
May 12, 2022

Conversation

fyrestone
Copy link
Contributor

What do these changes do?

  • Use @pytest_asyncio.fixture instead of @pytest.fixture for async fixtures.

Related issue number

Fixes #3024

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@fyrestone fyrestone self-assigned this May 11, 2022
@qinxuye qinxuye added this to the v0.10.0a1 milestone May 12, 2022
qinxuye
qinxuye approved these changes May 12, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chaokunyang
chaokunyang approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang
Copy link
Contributor

chaokunyang commented May 12, 2022 •
edited
Loading

Just FYI, another way is using auto mode in pytest.ini:

# pytest.ini
[pytest]
...
asyncio_mode=auto

Using @pytest_asyncio.fixture looks good to me too.

@qinxuye qinxuye merged commit 4be160f into mars-project:master May 12, 2022
wjsi added a commit to wjsi/mars that referenced this pull request May 23, 2022
@wjsi
Revert "Use @pytest_asyncio.fixture instead of @pytest.fixture for as…
fcdf679 
…ync fixtures (mars-project#3025)"

This reverts commit 4be160f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng Awaiting requested review from hekaisheng

@wjsi wjsi Awaiting requested review from wjsi

Assignees

@fyrestone fyrestone

Labels
type: tests
Projects
None yet
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.

Too many DeprecationWarning in CI logs
3 participants
@fyrestone @chaokunyang @qinxuye