Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dump remote tracebacks to make local ones more friendly #3028

Merged
merged 2 commits into from
May 13, 2022
Merged

Dump remote tracebacks to make local ones more friendly #3028

merged 2 commits into from
May 13, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented May 12, 2022

What do these changes do?

Dump remote tracebacks to make local ones more friendly. Also upgrade bundled tblib to 1.7.0.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added type: enhancement request to be backported Indicate that the PR need to be backported to stable branch labels May 12, 2022
@wjsi wjsi added this to the v0.10.0a1 milestone May 12, 2022
@wjsi wjsi marked this pull request as ready for review May 12, 2022 11:01
@wjsi wjsi requested review from qinxuye and hekaisheng as code owners May 12, 2022 11:01
qinxuye
qinxuye approved these changes May 12, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit e085051 into mars-project:master May 13, 2022
@wjsi wjsi deleted the enh/remote_tb branch May 13, 2022 02:32
wjsi added a commit to wjsi/mars that referenced this pull request May 13, 2022
@wjsi
Dump remote tracebacks to make local ones more friendly (mars-project…
ac6af9b 
…#3028)
wjsi added a commit to wjsi/mars that referenced this pull request May 13, 2022
@wjsi
Dump remote tracebacks to make local ones more friendly (mars-project…
b9bb156 
…#3028)
@wjsi wjsi mentioned this pull request May 13, 2022
Merged
qinxuye pushed a commit that referenced this pull request May 13, 2022
@wjsi
[BACKPORT] Dump remote tracebacks to make local ones more friendly (#…
1bb2c5c 
…3028) (#3030)
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hekaisheng hekaisheng hekaisheng approved these changes

@qinxuye qinxuye qinxuye approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported type: enhancement request
Projects
None yet
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.
3 participants
@wjsi @qinxuye @hekaisheng