Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine ThreadedServiceContext.get_chunks_meta usage #3037

Merged
merged 4 commits into from
May 16, 2022
Merged

Refine ThreadedServiceContext.get_chunks_meta usage #3037

merged 4 commits into from
May 16, 2022

Conversation

fyrestone
Copy link
Contributor

What do these changes do?

Some operands call ThreadedServiceContext.get_chunks_meta when executing, which is unnecessary because the iterative tiling updates the meta to the chunks. The operands have enough meta for executing.

  • TensorGetShape
    • yield a.chunks before the operand is constructed.
  • ChunkStandardizeRangeIndex
    • yield the input chunks of standardize_range_index before the operand is constructed.
  • RemoteFunction
    • yield the tileable inputs before the operand is executed.

Related issue number

#2893

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@fyrestone fyrestone self-assigned this May 16, 2022
@fyrestone fyrestone marked this pull request as ready for review May 16, 2022 10:57
@fyrestone fyrestone requested a review from a team as a code owner May 16, 2022 10:57
@qinxuye qinxuye added type: enhancement request to be backported Indicate that the PR need to be backported to stable branch mod: task service labels May 16, 2022
@qinxuye qinxuye added this to the v0.10.0a1 milestone May 16, 2022
qinxuye
qinxuye approved these changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhongchun
zhongchun approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@zhongchun zhongchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qinxuye qinxuye merged commit 4dabb97 into mars-project:master May 16, 2022
wjsi pushed a commit to wjsi/mars that referenced this pull request May 23, 2022
@fyrestone @wjsi
Refine ThreadedServiceContext.get_chunks_meta usage (mars-project#3037)
8f91052
@wjsi wjsi mentioned this pull request May 23, 2022
Merged
wjsi added a commit that referenced this pull request May 23, 2022
@wjsi
[BACKPORT] Refine ThreadedServiceContext.get_chunks_meta usage (#3037) (
540f71f 
#3067)

Co-authored-by: 刘宝 <po.lb@antfin.com>
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongchun zhongchun zhongchun approved these changes

@qinxuye qinxuye qinxuye approved these changes

Assignees

@fyrestone fyrestone

Labels
backported already PR has been backported mod: task service type: enhancement request
Projects
None yet
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.
4 participants
@fyrestone @qinxuye @zhongchun @wjsi