Shuffle both sides at the same time for md.merge
#3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hekaisheng
added
type: enhancement
|
As this PR changes the tile logic of merge, it will affect assign time which make asv benchmark fail in CI. |
hekaisheng
added a commit
to hekaisheng/mars
that referenced
this pull request
May 23, 2022
(cherry picked from commit 3b0130e)
wjsi
pushed a commit
that referenced
this pull request
May 23, 2022
wjsi
added
backported already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
For now, we shuffle left and right separately and make reducer data locate in different workers, this leads to additional transfer when execute merge operand. This PR only shuffles once for both left and right, so that reducer data locate in same worker and no transfer for following execution.
Related issue number
Fixes #xxxx
Check code requirements