Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch pandas to make pickle compatible between 1.2 and 1.3 #3047

Merged
merged 2 commits into from
May 18, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented May 18, 2022

What do these changes do?

Pandas 1.3 renamed a function which caused pickling and unpickling between these two versions causing errrors (see https://stackoverflow.com/questions/68625748/attributeerror-cant-get-attribute-new-block-on-module-pandas-core-internal).

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added type: bug Something isn't working mod: serialization labels May 18, 2022
@wjsi wjsi added this to the v0.10.0a1 milestone May 18, 2022
@wjsi wjsi added the to be backported Indicate that the PR need to be backported to stable branch label May 18, 2022
@qinxuye qinxuye marked this pull request as ready for review May 18, 2022 10:10
@qinxuye qinxuye requested a review from a team as a code owner May 18, 2022 10:10
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 7840183 into mars-project:master May 18, 2022
@wjsi wjsi deleted the bugfix/compat_pd_serial branch May 18, 2022 10:24
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported already PR has been backported mod: serialization type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants