Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ray] Destroy Ray executor when the task finish #3049

Merged
merged 3 commits into from
May 19, 2022
Merged

[Ray] Destroy Ray executor when the task finish #3049

merged 3 commits into from
May 19, 2022

Conversation

fyrestone
Copy link
Contributor

@fyrestone fyrestone commented May 18, 2022 •
edited
Loading

What do these changes do?

Mars tests share one same session in CI, but all the TaskProcessorActor, TaskProcessor and TaskExecuter are not destroyed. So, this PR

  • Add a destroy API to the TaskExecutor.
  • Implement RayTaskExecutor.destory.

Related issue number

#2893

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@fyrestone fyrestone self-assigned this May 18, 2022
@fyrestone fyrestone marked this pull request as ready for review May 18, 2022 10:34
@fyrestone fyrestone requested a review from a team as a code owner May 18, 2022 10:34
qinxuye
qinxuye approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye added the type: enhancement request label May 19, 2022
@qinxuye qinxuye added this to the v0.10.0a1 milestone May 19, 2022
@qinxuye qinxuye added the to be backported Indicate that the PR need to be backported to stable branch label May 19, 2022
zhongchun
zhongchun approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@zhongchun zhongchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fyrestone fyrestone merged commit bc37acf into mars-project:master May 19, 2022
wjsi pushed a commit to wjsi/mars that referenced this pull request May 24, 2022
@fyrestone @wjsi
[Ray] Destroy Ray executor when the task finish (mars-project#3049)
7a8b896 
* Destroy Ray executor when the task finish

* Fix

* Fix

Co-authored-by: 刘宝 <po.lb@antfin.com>
@wjsi wjsi mentioned this pull request May 24, 2022
Merged
qinxuye pushed a commit that referenced this pull request May 24, 2022
@wjsi
[BACKPORT] [Ray] Destroy Ray executor when the task finish (#3049) (#…
4512041 
…3074)
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongchun zhongchun zhongchun approved these changes

@qinxuye qinxuye qinxuye approved these changes

Assignees

@fyrestone fyrestone

Labels
backported already PR has been backported mod: task service type: enhancement request
Projects
None yet
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.
3 participants
@fyrestone @qinxuye @zhongchun