-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ray] Fix ray worker failover #3080
Merged
chaokunyang
merged 10 commits into
mars-project:master
from
chaokunyang:support_worker_failover_for_ray_master
May 28, 2022
Merged
[Ray] Fix ray worker failover #3080
chaokunyang
merged 10 commits into
mars-project:master
from
chaokunyang:support_worker_failover_for_ray_master
May 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaokunyang
force-pushed
the
support_worker_failover_for_ray_master
branch
12 times, most recently
from
May 28, 2022 03:06
25acb25
to
e7ecf8b
Compare
chaokunyang
changed the title
[Ray] support ray worker failover for ray master
[Ray] Fix ray worker failover
May 28, 2022
chaokunyang
force-pushed
the
support_worker_failover_for_ray_master
branch
from
May 28, 2022 05:34
787dec6
to
f6f33ca
Compare
qinxuye
approved these changes
May 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qinxuye
added
type: bug
Something isn't working
mod: actor
to be backported
Indicate that the PR need to be backported to stable branch
mod: ray integration
labels
May 28, 2022
zhongchun
reviewed
May 28, 2022
zhongchun
approved these changes
May 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
qinxuye
pushed a commit
to qinxuye/mars
that referenced
this pull request
Jun 6, 2022
* make failover work with laster ray master * fix max_task_retries * fix _get_actor * fix compatibility * fix retry actor state task * fix subppol restart * skip test_ownership_when_scale_in * revert alive check interval * lint * lint (cherry picked from commit 0263954)
qinxuye
pushed a commit
that referenced
this pull request
Jun 6, 2022
qinxuye
added
backported already
PR has been backported
and removed
to be backported
Indicate that the PR need to be backported to stable branch
labels
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backported already
PR has been backported
mod: actor
mod: ray integration
type: bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In ray master, If a actor created with
max_restarts=-1
is restarting, call actor method will raise exception instead of pending in caller. This PR fix it by specifingmax_retries=-1
when querying actor state.Related issue number
Fixes #3079
Check code requirements