Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify router clean up when pools or clusters ends #3086

Merged
merged 3 commits into from
May 25, 2022
Merged

Simplify router clean up when pools or clusters ends #3086

merged 3 commits into from
May 25, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented May 25, 2022

What do these changes do?

Simplify router clean up when pools or clusters ends.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added type: enhancement request mod: actor to be backported Indicate that the PR need to be backported to stable branch labels May 25, 2022
@wjsi wjsi added this to the v0.10.0a1 milestone May 25, 2022
@wjsi wjsi requested a review from a team as a code owner May 25, 2022 06:50
qinxuye
qinxuye approved these changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit e798aed into mars-project:master May 25, 2022
@wjsi wjsi deleted the enh/simplify_router_clean branch May 25, 2022 09:36
wjsi added a commit to wjsi/mars that referenced this pull request May 25, 2022
@wjsi
Simplify router clean up when pools or clusters ends (mars-project#3086)
57ab8c4
@wjsi wjsi mentioned this pull request May 25, 2022
Merged
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hekaisheng hekaisheng hekaisheng approved these changes

@qinxuye qinxuye qinxuye approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: actor type: enhancement request
Projects
None yet
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.
3 participants
@wjsi @qinxuye @hekaisheng