Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test_session_set_progress more stable under Ray tests #3103

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Make test_session_set_progress more stable under Ray tests #3103

merged 3 commits into from
Jun 1, 2022

Conversation

zhongchun
Copy link
Contributor

@zhongchun zhongchun commented May 31, 2022 •
edited
Loading

What do these changes do?

Fix test_session_set_progress when running on backend ray.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@zhongchun zhongchun requested a review from a team as a code owner May 31, 2022 14:21
@qinxuye qinxuye added this to the v0.10.0a1 milestone Jun 1, 2022
@qinxuye qinxuye added the to be backported Indicate that the PR need to be backported to stable branch label Jun 1, 2022
chaokunyang
chaokunyang approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi changed the title Fix progress test Make test_session_set_progress more stable under Ray tests Jun 1, 2022
wjsi
wjsi approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit f71d4ae into mars-project:master Jun 1, 2022
wjsi pushed a commit to wjsi/mars that referenced this pull request Jun 1, 2022
@zhongchun @wjsi
Make test_session_set_progress more stable under Ray tests (mars-pr…
43a87a4 
…oject#3103)
@wjsi wjsi mentioned this pull request Jun 1, 2022
Merged
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

@wjsi wjsi wjsi approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported type: tests
Projects
None yet
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.
4 participants
@zhongchun @wjsi @chaokunyang @qinxuye